runDialog: Ignore expected IO errors while enumerating $PATH

$PATH might contain non-existent or non-directory entries. Ignore
those error cases.

https://bugzilla.gnome.org/show_bug.cgi?id=696064

diff --git a/js/ui/runDialog.js b/js/ui/runDialog.js
index bedea40f85fa61ba05b231d8d985b437ca6c5ff2..9d288d92a8732d45e312f81ecd3514d6744d6ec5 100644 (file)
--- a/js/ui/runDialog.js
+++ b/js/ui/runDialog.js
@@ -161,16 +161,22 @@ const RunDialog = new Lang.Class({
         let paths = GLib.getenv('PATH').split(':');
         paths.push(GLib.get_home_dir());
         let someResults = paths.map(function(path) {
-            let file = Gio.File.new_for_path(path);
-            let fileEnum = file.enumerate_children('standard::name', Gio.FileQueryInfoFlags.NONE, null);
-            let info;
             let results = [];
-            while ((info = fileEnum.next_file(null))) {
-                let name = info.get_name();
-                if (name.slice(0, text.length) == text)
-                    results.push(name);
+            try {
+                let file = Gio.File.new_for_path(path);
+                let fileEnum = file.enumerate_children('standard::name', Gio.FileQueryInfoFlags.NONE, null);
+                let info;
+                while ((info = fileEnum.next_file(null))) {
+                    let name = info.get_name();
+                    if (name.slice(0, text.length) == text)
+                        results.push(name);
+                }
+            } catch (e if (!e.matches(Gio.IOErrorEnum, Gio.IOErrorEnum.NOT_FOUND) &&
+                           !e.matches(Gio.IOErrorEnum, Gio.IOErrorEnum.NOT_DIRECTORY))) {
+                log(e);
+            } finally {
+                return results;
             }
-            return results;
         });
         let results = someResults.reduce(function(a, b) {
             return a.concat(b);